Skip to content

feat(cacheserver): Implement Status.Conditions and Status.Phase for CacheServer#185

Open
KevinGimbel wants to merge 1 commit into
kcp-dev:mainfrom
KevinGimbel:182/cache-server-status
Open

feat(cacheserver): Implement Status.Conditions and Status.Phase for CacheServer#185
KevinGimbel wants to merge 1 commit into
kcp-dev:mainfrom
KevinGimbel:182/cache-server-status

Conversation

@KevinGimbel
Copy link
Copy Markdown
Contributor

Summary

Implement Conditions and Status Phases for Cache Server.

What Type of PR Is This?

/kind feature

Related Issue(s)

Fixes #182

Release Notes

feat: Implement Status.Conditions and Status.Phase for CacheServer

@kcp-ci-bot kcp-ci-bot added kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Mar 26, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kcp-ci-bot kcp-ci-bot added dco-signoff: no Indicates the PR's author has not signed the DCO. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 26, 2026
@kcp-ci-bot
Copy link
Copy Markdown
Contributor

Hi @KevinGimbel. Thanks for your PR.

I'm waiting for a kcp-dev member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kcp-ci-bot kcp-ci-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2026
@KevinGimbel
Copy link
Copy Markdown
Contributor Author

The easy part is done.

Now, the harder part starts of actually filling the Conditions and Phases. :D

Signed-off-by: Kevin Gimbel <kevin@gimbel.dev>
@KevinGimbel KevinGimbel force-pushed the 182/cache-server-status branch from 2e796de to 214035f Compare March 26, 2026 10:59
@kcp-ci-bot kcp-ci-bot added dco-signoff: yes Indicates the PR's author has signed the DCO. and removed dco-signoff: no Indicates the PR's author has not signed the DCO. labels Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates the PR's author has signed the DCO. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feature: Implement CacheServer Status similar to other types

2 participants