Updates for get_feature_ids(), get_features()#7
Open
kkellerlbl wants to merge 20 commits into
Open
Conversation
Added LWP::Protocol::https to require list Added Getopt support to bin/ scripts; changed default url to ci (though I'm not sure that's good) Modified travis.yml to explicitly state url for calling bin scripts
Support for get_feature_ids() to return lists of tuples instead of lists of feature_ids (filter by region not working yet) Support for get_features() to accept a list of tuples instead of a list of ids
Change default service endpoint back to localhost:9103
Changed default service endpoint to localhost:9101
Collaborator
Author
|
Please do not merge yet, I think there's one more thing that's causing Travis to fail. |
…em to be too big. If the output is needed I should try to make it less voluminous.
Current coverage is
|
kkellerlbl
changed the title
Collaborator
Author
|
Tests are now passing again, so I think this is safe to merge. I will wait a little in case people want to review it first. |
Collaborator
Author
There was a problem hiding this comment.
I think that the get_feature_ids() code is still compatible for when PR 133 is rejected.
Collaborator
Author
|
I think that the remaining incompatible changes in this PR are to the Thrift specs, which can just be regenerated. It looks like the rest of the changes are still okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for changes to data_api get_feature_ids() and get_features(). This PR points to my fork of data_api for Travis builds; that should be updated when the PR for data_api gets merged.