Skip to content

Upgrade nginx#24

Open
bio-boris wants to merge 20 commits into
masterfrom
DEVOPS-2771
Open

Upgrade nginx#24
bio-boris wants to merge 20 commits into
masterfrom
DEVOPS-2771

Conversation

@bio-boris
Copy link
Copy Markdown

No description provided.

Copilot AI review requested due to automatic review settings May 14, 2026 16:40
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 16 changed files in this pull request and generated 8 comments.

Files not reviewed (1)
  • .idea/.gitignore: Language not supported

Comment thread Dockerfile
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread Dockerfile Outdated
Comment thread .idea/.gitignore
Comment thread .github/workflows/managed_build.yaml
Comment thread README.md
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 16 changed files in this pull request and generated 6 comments.

Files not reviewed (1)
  • .idea/.gitignore: Language not supported

Comment thread README.md
# Passing environment variables through Nginx to the narrative containers

This section is no longer relevant. Narrative containers (and their environment variables) are managed by traefiker.
# NGINX No newline at end of file
Comment thread Dockerfile
Comment thread Dockerfile
Comment thread .github/workflows/managed_build.yaml
Comment thread .idea/.gitignore
Comment thread Dockerfile Outdated
Copy link
Copy Markdown
Member

@kkellerlbl kkellerlbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment but probably not critical.

Comment thread Dockerfile
"-stdout", "/var/log/nginx/access.log", \
"-stdout", "/var/log/nginx/error.log", \
"nginx" ]
FROM openresty/openresty:1.29.2.4-alpine-fat@sha256:af355ebd6f01e580823b6718e8a2e39be3b45d9437fc92144e43ac72020f7461
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to use a specific SHA as the base image?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants