CDM-86: Cancel jobs part 1 #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates various lower level code for job canceling, as well as some minor cleanup. * condor client: * adds cancel method * updates stats calculations to allow for canceled jobs missing fields in the ClassAd * explicitly specifies graceful shutdown when canceling jobs * container runner & executor * Updates log streaming to use threads for both streams to prevent blocking the main loop and thus signal handling. * Shuts down the docker container on getting a sigterm and exits. * Adds a simple script for manually running the container runner * Adds an argument to job_state.get_job to allow getting the admin details for a job, but only if the user owns the job. * Updates the run_job script to exec the python code so signals propagate.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
==========================================
- Coverage 54.33% 54.23% -0.10%
==========================================
Files 68 68
Lines 5632 5646 +14
==========================================
+ Hits 3060 3062 +2
- Misses 2572 2584 +12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Tianhao-Gu
approved these changes
Jan 7, 2026
Comment on lines
+102
to
+103
| signal.signal(signal.SIGTERM, cleanup) | ||
| signal.signal(signal.SIGINT, cleanup) |
Collaborator
There was a problem hiding this comment.
Do we need to restore signal in the finally block?
Member
Author
There was a problem hiding this comment.
You mean remove the signal handler? If so, I don't think so, it's a no op on the container and the sys.exit() call is effectively what would happen if the signal wasn't caught, so after the container has exited it shouldn't change the behavior unless I'm missing something
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates various lower level code for job canceling, as well as some minor cleanup.
condor client:
container runner & executor
Adds an argument to job_state.get_job to allow getting the admin details for a job, but only if the user owns the job.
Updates the run_job script to exec the python code so signals propagate.