Skip to content

Conversation

@MrCreosote
Copy link
Member

@MrCreosote MrCreosote commented Aug 11, 2025

Changes that are functionally the same as the changes in this commit are already running on prod. Due to refactoring of how configuration works, the changes on the ee2 branch could not be exactly replicated here, but they should be functionally the same.

This is impossible to test other than in situ.

Fixes: #88

For comparison, the ee2 branch changes: https://github.com/kbase/jobRunner/compare/68d9c2710bb16e362662fb1a4db2da5afa7ddfd7..ee2

Changes that are functionally the same as the changes in this commit are
already running on prod. Due to refactoring of how configuration works,
the changes on the ee2 branch could not be exactly replicated here, but
they should be functionally the same.

This is impossible to test other than in situ.
@MrCreosote MrCreosote requested a review from bio-boris August 11, 2025 20:57
@codecov
Copy link

codecov bot commented Aug 11, 2025

Codecov Report

❌ Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.52%. Comparing base (4c86ab9) to head (32db093).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
JobRunner/JobRunner.py 16.66% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
- Coverage   80.85%   80.52%   -0.33%     
==========================================
  Files          13       13              
  Lines        1165     1171       +6     
==========================================
+ Hits          942      943       +1     
- Misses        223      228       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MrCreosote MrCreosote merged commit 08dc5e8 into main Aug 11, 2025
10 of 12 checks passed
@MrCreosote MrCreosote deleted the dev_kb_sdk_plus branch August 11, 2025 21:28
@bio-boris bio-boris mentioned this pull request Aug 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port changes from ee2 branch into main

3 participants