Fail on bad check job job IDs #113
Conversation
Update the callback server to keep track of what job IDs exist. Previously it couldn't tell the difference between an incomplete job and a job that never existed.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #113 +/- ##
==========================================
- Coverage 81.03% 80.85% -0.19%
==========================================
Files 13 13
Lines 1155 1165 +10
==========================================
+ Hits 936 942 +6
- Misses 219 223 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Standard coverage issue where pytest can't see the lines being covered since they're running in a different Sanic worker process |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the callback server to track job IDs and differentiate between incomplete jobs and non-existent jobs. Previously, the server couldn't distinguish between these cases when checking job status.
- Added job ID validation to ensure only valid UUIDs are accepted
- Implemented tracking of all submitted job IDs in the outputs dictionary
- Enhanced error handling to return specific error messages for invalid or non-existent job IDs
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| JobRunner/callback_server.py | Added job ID validation, tracking, and enhanced error handling for check job operations |
| test/test_callback_server_integration.py | Added comprehensive test coverage for job validation and error scenarios |
| import os | ||
| import pytest | ||
| import requests | ||
| import socket |
There was a problem hiding this comment.
The socket import is moved but appears to be duplicated. There's already an import socket statement after line 16 that should be removed to avoid redundancy.
There was a problem hiding this comment.
That "duplicate line" is a deletion
Update the callback server to keep track of what job IDs exist. Previously it couldn't tell the difference between an incomplete job and a job that never existed.