External highlighter and omit initial callbacks#110
Open
wellenvogel wants to merge 13 commits intokazzkiq:masterfrom
Open
External highlighter and omit initial callbacks#110wellenvogel wants to merge 13 commits intokazzkiq:masterfrom
wellenvogel wants to merge 13 commits intokazzkiq:masterfrom
Conversation
added 8 commits
March 2, 2020 20:50
Owner
|
This is an interesting feature, but would lead to breaks in current API and thus should be released in the next Major version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm trying to use codeflask in my avnav project.
There were 2 drawbacks:
So I introduced an option for the highlighter function: highLighter. If you omit it, there is no highlighter at all. This way I could completely remove prism (of I guess it is needed for test - I was not really able to run them).
The initial call looks like
var editor=new Flask('editor',{ language:'js', highLighter:Prism.highlightElement, noInitialCallback:true}Maybe you would be interested in considering this PR - or some similar solution.
Best regards
Andreas