fix: resolve PipeWire sink name mismatch for active output detection#492
Open
Jimoz77 wants to merge 1 commit intokavishdevar:mainfrom
Open
fix: resolve PipeWire sink name mismatch for active output detection#492Jimoz77 wants to merge 1 commit intokavishdevar:mainfrom
Jimoz77 wants to merge 1 commit intokavishdevar:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Currently, isActiveOutputDeviceAirPods() always returns false on Fedora/PipeWire systems. PipeWire (and often PulseAudio) replaces the colons (:) in MAC addresses with underscores (_) when naming sinks (e.g., bluez_output.08_FF_44_51_E7_6A.1).
Because the function uses a strict contains() with the original MAC address format (08:FF...), it fails to match the sink name, breaking the auto-pause and resume features for AirPods Max/Pro.
Changes:
-Created a formatted copy of the MAC address where colons are replaced by underscores, if the MAC address was correct nothing changes.
-Changed the contains() check to use Qt::CaseInsensitive for safer matching across different Linux audio implementations.
Testing:
Tested successfully on Fedora 42 Asahi Remix with PipeWire. Auto-pause and resume now work perfectly when removing/putting on the AirPods Max.