Skip to content

Conversation

@kaspernj
Copy link
Owner

@kaspernj kaspernj commented Jan 1, 2026

Summary

  • reload abilities on Devise sign-in/sign-out in useCanCan
  • use useEffect for side effects with dependency list
  • add system spec for ability refresh after sign-in

Testing

  • yarn --cwd /home/dev/Development/api_maker/npm-api-maker eslint src/use-can-can.js
  • bundle exec rubocop spec/system/can_can/loader_spec.rb
  • xvfb-run bundle exec rspec spec/system/can_can/loader_spec.rb (fails: missing /packs/js assets in dummy app)

@kaspernj kaspernj self-assigned this Jan 1, 2026
@kaspernj kaspernj added the bug Something isn't working label Jan 1, 2026
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@kaspernj kaspernj merged commit 8c96c4f into master Jan 2, 2026
1 check failed
@kaspernj kaspernj deleted the fix/use-can-can-signin-refresh branch January 2, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants