Skip to content

Potentially fix for single character string keycodes in 1.9 and above #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
beckyconning wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Potentially fix for single character string keycodes in 1.9 and above #3

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
636b5d9
Potentially fix for single character string keycodes in 1.9 and above
Jun 14, 2013
0fbccbc
Fixing type for ruby >= 1.9
Jun 17, 2013
2fca0d2
Update vnc.rb
Jun 17, 2013
2e4d012
Fixing Ruby >= 1.9 issues
Jun 17, 2013
c0a2bfb
Update vnc.rb
Jun 17, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions lib/net/vnc.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ def type text, options={}
packet = 0.chr * 8
packet[0] = 4.chr
text.split(//).each do |char|
packet[7] = char[0]
packet[7] = char.ord.chr
packet[1] = 1.chr
socket.write packet
packet[1] = 0.chr
Expand Down Expand Up @@ -178,11 +178,11 @@ def key_press(*args)
end

def get_key_code which
if String === which
if which.class == String
if which.length != 1
raise ArgumentError, 'can only get key_code of single character strings'
end
which[0]
which[0].ord
else
KEY_MAP[which]
end
Expand Down Expand Up @@ -292,7 +292,7 @@ def packet_reading_thread
begin
break if @packet_reading_state != :loop
next unless IO.select [socket], nil, nil, 2
type = socket.read(1)[0]
type = socket.read(1).ord
read_packet type
rescue
warn "exception in packet_reading_thread: #{$!.class}:#{$!}"
Expand Down