-
Notifications
You must be signed in to change notification settings - Fork 353
Add comment system, highlights view, and markdown support #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
taylorren
wants to merge
14
commits into
karpathy:master
Choose a base branch
from
taylorren:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Features added: - Personal comments (no AI, editable/deletable) - Highlights view page for each book - Markdown rendering for AI responses - Multiple highlights support with Range API - Cover image display in library - Web upload functionality Improvements: - Fixed highlight rendering for multiple items - Color-coded highlights (yellow=AI, green=comments) - Filter highlights by type - Clean up unnecessary files and debug code - Updated documentation
New Features: - Export highlights to markdown with AI context warning - Drag and drop EPUB upload - Modal popup for internal links (footnotes, author comments) - Keyboard navigation (arrow keys for prev/next chapter) - Sticky top navigation bar - Clickable book covers in library - Delete functionality for all highlight types - Tooltips on highlights showing type UI Improvements: - Color-coded highlights (yellow=fact check, blue=discussion, green=comment) - Removed icon overlays (cleaner text flow) - Professional AI button (replaced robot emoji) - Fixed HTML structure issues - Better panel visibility handling Bug Fixes: - Fixed highlight rendering for multiple items on same page - Fixed context length (only send selected text to AI) - Handle EPUB internal links with filenames - Proper modal closing behavior
New Features: - Reading settings panel with gear icon in navigation - Font family selection (8 options including Chinese fonts) - Font size adjustment (14-24px slider) - Line height adjustment (1.4-2.2 slider) - Settings persist in localStorage across sessions Updated: - README with comprehensive feature list - Organized features by category - Added keyboard shortcuts documentation
…ghts display, update branding - Fix image route ordering to properly serve cover images - Remove _data suffix from book folders for cleaner names - Fix highlight rendering for multi-paragraph selections - Apply highlight styles directly to block elements - Add distinct colors for fact_check/discussion/comment highlights - Update app title to 'My Reader with AI' - Add book emoji favicon - Restore .env.example file
Author
|
Manged to add many new features. |
…ussion with academic depth
…ore, and TOC auto-scroll
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features added: