Conversation
|
This change is part of the following stack: Change managed by git-spice. |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves issues in the example application by updating core dependencies and significantly refining the database code generation process. The changes standardize how bulk inserts are handled across different SQL drivers and align the generated code with the latest Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14 +/- ##
=======================================
Coverage 28.83% 28.83%
=======================================
Files 6 6
Lines 697 697
=======================================
Hits 201 201
Misses 485 485
Partials 11 11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
The pull request updates the Go version to 1.25.7 and adds the github.com/lib/pq dependency. It introduces a multi-database sqlc-multi-db generation setup, leading to changes in generated code across mysql, postgres, and sqlite database packages. Key changes include renaming AddBookTagsParams fields to Column1 and Column2 in generated_models.go and corresponding updates in wrapper functions, along with extensive reformatting and duplication of SQL queries as comments in generated querier.go and query.*.sql.go files. Review comments highlight the need to improve the descriptiveness of Column1 and Column2 by using sqlc.arg() in SQL queries, and point out redundant rows.Close() calls in mysqldb and sqlitedb generated code that should be removed.
- Use sqlc.arg() to name unnest parameters in AddBookTags query, generating BookIds/TagIds instead of Column1/Column2 - Remove redundant rows.Close() calls in MySQL and SQLite generated files for GetBookTags, GetBooksByAuthor, and ListBooks functions Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
No description provided.