Add methods for serialization#48
Closed
UserUnknownFactor wants to merge 1 commit intokaitai-io:masterfrom
Closed
Conversation
UserUnknownFactor
force-pushed
the
master
branch
from
def9b79 to
e2a7e39
Compare
Contributor
KOLANICH
reviewed
Aug 3, 2020
KOLANICH
reviewed
Aug 3, 2020
KOLANICH
reviewed
Aug 3, 2020
KOLANICH
suggested changes
Aug 3, 2020
Contributor
KOLANICH
left a comment
KOLANICH
left a comment
There was a problem hiding this comment.
In its current state it is inacceptable to be merged.
UserUnknownFactor
force-pushed
the
master
branch
2 times, most recently
from
80a8585 to
3113da9
Compare
KOLANICH
reviewed
Aug 3, 2020
dgelessus
reviewed
Aug 3, 2020
UserUnknownFactor
force-pushed
the
master
branch
from
3113da9 to
156427a
Compare
Author
|
Example of code: #48 (comment) |
UserUnknownFactor
force-pushed
the
master
branch
from
156427a to
a09352a
Compare
Author
|
I removed all changes related to possible compiler implementation and alignment, I'll do them as a separate PRs. |
UserUnknownFactor
force-pushed
the
master
branch
from
a09352a to
e15a9ad
Compare
generalmimon
reviewed
Aug 5, 2020
generalmimon
reviewed
Aug 5, 2020
generalmimon
reviewed
Aug 5, 2020
generalmimon
requested changes
Aug 5, 2020
Member
generalmimon
left a comment
generalmimon
left a comment
There was a problem hiding this comment.
I request some changes in the comments above.
UserUnknownFactor
force-pushed
the
master
branch
4 times, most recently
from
3938615 to
24e5259
Compare
Author
|
This should be enough, right? |
generalmimon
reviewed
Aug 9, 2020
UserUnknownFactor
force-pushed
the
master
branch
from
24e5259 to
34526fd
Compare
KOLANICH
reviewed
Aug 10, 2020
KOLANICH
reviewed
Aug 10, 2020
KOLANICH
reviewed
Aug 10, 2020
UserUnknownFactor
force-pushed
the
master
branch
from
34526fd to
19c8f9d
Compare
UserUnknownFactor
force-pushed
the
master
branch
4 times, most recently
from
656b27f to
787b148
Compare
KOLANICH
reviewed
Aug 10, 2020
UserUnknownFactor
force-pushed
the
master
branch
from
787b148 to
9341783
Compare
UserUnknownFactor
force-pushed
the
master
branch
from
9341783 to
688b43b
Compare
UserUnknownFactor
force-pushed
the
master
branch
from
688b43b to
c5b707a
Compare
UserUnknownFactor
force-pushed
the
master
branch
from
c5b707a to
e178994
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to have the python library prepared for serialization functionality.