-
Notifications
You must be signed in to change notification settings - Fork 26
Add StackOverflow username validator #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StackOverflow username validator #80
Conversation
VamatoHD
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation looks solid! I ran some tests, and it appears to work perfectly.
I'll run some more tests and hopefully approve.
Co-authored-by: Vamato <62358492+VamatoHD@users.noreply.github.com>
Fort503
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Fort503
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
|
Wait @Fort503 Why you closed the PR? I think you misunderstood, your PR is perfectly fine we were just discussing about changes. |
|
Oh, alright, alright, thanks. |
|
@VamatoHD Do you want to make any changes? Or else I am going to merge it just let me know. |
Title
Add StackOverflow username validator
Description
This Pull Request adds a new validator for StackOverflow, located in
community/stackoverflow.pyThe StackOverflow user search endpoint:
https://stackoverflow.com/users/filter?search=
always returns HTTP 200, regardless of whether the user exists or not. Therefore, the validator uses
generic_validate()and inspects the HTML response body.The detection logic follows these rules:
"No users matched your search."→ the username is available.>{username}<→ the username is taken.