Link fixes#1950
Open
kristin-kronstain-brown wants to merge 2 commits into
Open
Conversation
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
kristin-kronstain-brown
requested review from
iplay88keys,
jmhbh and
supreme-gg-gg
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates several outdated documentation links in API type comments to their current canonical locations.
Changes:
- Updates Gateway API multi-namespace docs anchor from
#cross-namespace-routingto#cross-namespace-route-attachmentin three files. - Updates the A2A protocol repository link from
github.com/google/A2Atogithub.com/a2aproject/A2Ain v1alpha1 and v1alpha2 agent types. - Adds a trailing space inside the adk-python issue link comment.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| go/api/v1alpha2/remotemcpserver_types.go | Fix Gateway API anchor link in AllowedNamespaces doc comment. |
| go/api/v1alpha2/common_types.go | Fix Gateway API anchor link in FromNamespaces doc comment. |
| go/api/v1alpha2/agent_types.go | Fix Gateway API anchor and A2A repo link; minor edit to adk-python link comment. |
| go/api/v1alpha1/agent_types.go | Update A2A repo link in A2AConfig doc comment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
peterj
reviewed
Jun 1, 2026
Collaborator
|
thanks for the PR! Can you also make sure you run |
Signed-off-by: Kristin Brown <kristin.brown@solo.io>
kristin-kronstain-brown
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
peterj
approved these changes
Jun 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: update stale and broken URLs in Go API type comments
Three sets of comment URLs in the API type definitions were either redirecting or pointing to renamed anchors, causing failures in downstream docs link checking.
Changes
github.com/google/A2A→github.com/a2aproject/A2A(v1alpha1andv1alpha2agent_types.go): The A2A project moved to a new GitHub org. Updated the link in thea2aConfigfield description.#cross-namespace-routing→#cross-namespace-route-attachment(agent_types.go,remotemcpserver_types.go,common_types.go): The Gateway API docs renamed this anchor. The old fragment no longer exists on theguides/multiple-ns/page.adk-python/issues/3921)(agent_types.go): Added a space before the closing parenthesis so URL parsers don't include it as part of the link.These comments flow into the auto-generated API reference docs via
crd-ref-docs, so fixing them here eliminates the link checker warnings in downstream doc sites.