Gate Agent CR templates behind enabled flags ( https://github.com/kagent-dev/kagent/issues/1169 ) #1197
+10
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benzaidfoued
requested review from
EItanya,
ilackarms and
yuval-k
as code owners
EItanya
requested changes
Jan 12, 2026
Contributor
EItanya
left a comment
EItanya
left a comment
There was a problem hiding this comment.
A couple comments here:
- The sub-charts don't need the
enabledpiece, it's just a feature of subcharts. - The parent chart already has sections for all of the agents
EItanya
reviewed
Jan 16, 2026
EItanya
reviewed
Jan 16, 2026
EItanya
previously approved these changes
Jan 16, 2026
Contributor
|
You will need to sign the commits before I can approve |
benzaidfoued
force-pushed
the
bug-fix
branch
2 times, most recently
from
a8c1141 to
35b14bd
Compare
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Signed-off-by: Foued Benzaid <benzaid.foued@gmail.com>
Author
ouach, done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gate Agent CR templates behind enabled flags .
Fix for : #1169