This repository was archived by the owner on Nov 24, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Standalone pact-replay tool #2207
Open
edmundnoble
wants to merge
12
commits into
pp/evm
Choose a base branch
from
push-trloyuomykku
base: pp/evm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f6939f to
394e7ea
Compare
394e7ea to
fcc8996
Compare
rsoeldner
approved these changes
Sep 23, 2025
cwtools/pact-replay/PactReplay.hs
Outdated
|
|
||
| liftIO $ readIORef failedOnChainRef | ||
| when anyFailed $ | ||
| error "some blocks failed" |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe count the number of failed blocks in one chunk.
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd love to count the total number of failures, that's a great idea.
| (Codec (runPutS . encodeBlockHash) (runGetS decodeBlockHash)) | ||
| ["BlockHeader", cidNs, "rank"] | ||
|
|
||
| !db = BlockHeaderDb cid |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the strictness annotation not needed anymore?
src/Chainweb/Chainweb.hs
Outdated
| , _chainwebLogger = logger | ||
| , _chainwebPeer = peerRes | ||
| , _chainwebManager = mgr | ||
| -- , _chainwebPactData = pactData |
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| -- , _chainwebPactData = pactData |
994c512 to
760f6a0
Compare
Change-Id: Id0000000fbd4c58b18ba9e4063c224da92b97b43
Change-Id: Id00000003f0e000a1190670dcce027a952183462
Change-Id: Id0000000d7901e0181766a784bb673ffabd8aa71
Change-Id: Id0000000c2ac1ace6bc1bbb8d21dfdc89e2b7ed9
Change-Id: Id0000000e02e4ac227e15f0d267484f3955af378
Otherwise the migration to BlockHistory2 happens before that table is even created on a mainnet db. Ideally, we probably just delete withPactService. Change-Id: Id000000076cfe813346a9b6fe0ae63c3237d5b03
Change-Id: Id000000074e2d41ff0d0254f3d31e9c712adc6e5
Change-Id: Id0000000255a7e431b00beb8388a10b63f4c7904
Unfortunately we write to rocksdb even when it's not necessary sometimes as an init step. c.f. initBlockHeaderDb Change-Id: Id00000005183459e1775505421e130ea688c3c9c
Change-Id: Id0000000b3bd3a0c6c952ae940e781b245af51d9
1. BlockHistoryMigration starts rewinding to the final block in BlockHistory and setting the consensus state to that block, as part of cleanup. (needs tests) 2. Many utilities moved from ChainwebPactDb to Backend.Utils. (these are not specific to PactDb though they are related to storage) 3. Stop maintaining a "latest" in ConsensusState table. This is only the latest row in BlockHistory table now. Change-Id: Id00000001c55cdeb49e0280cadaf17bb040a381f
Change-Id: Id000000068eb15bd1ff51bc3590ac087c73da495
760f6a0 to
7122976
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.