This repository was archived by the owner on Nov 24, 2025. It is now read-only.
Avoid duplicate pre-insert checks; #2140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwiegley
reviewed
Feb 13, 2025
edmundnoble
force-pushed
the
push-suqyztlxwumx
branch
from
bd51fb1 to
ecc03a0
Compare
Store a set of currently-being-inserted txs across in the mempool. This way we can avoid doing duplicate pre-insert checks, which is good, because those could take a while depending on what PactService is busy with. Change-Id: Id0000000759106e235d28e052289a229f49212ef
edmundnoble
force-pushed
the
push-suqyztlxwumx
branch
from
ecc03a0 to
9c11193
Compare
chessai
approved these changes
Feb 15, 2025
larskuhtz
approved these changes
Mar 31, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Store a set of currently-being-inserted txs across in the mempool. This way we can avoid doing duplicate pre-insert checks, which is good, because those could take a while depending on what PactService is busy with.
Change-Id: Id0000000759106e235d28e052289a229f49212ef