Fix tests on latest Node.js #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consistently use 2 space indentation
hthetiot
requested review from
dpwspoon and
jitsni
and removed request for
hthetiot
jitsni
reviewed
Aug 31, 2017
| if (!stream._ended) { | ||
| nextBucket.push(stream); | ||
| } else { | ||
| delete this._streamIds[stream.id]; |
Contributor
There was a problem hiding this comment.
I suppose _removeStream() delete the item in _streamIds
Contributor
|
looks good to me. |
Closed
Contributor
|
Thx @jselit it's on master and I will let you know once released on npm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After these commits, all tests pass in latest Node.js v4, v6 and v8; on Windows and Linux. All changes should be backward compatible.
This contains the changes in molnarg/node-http2#251, as well as some other fixes for things that are only in this fork.
db09362 tried to cleanup old streams, but it deletes them too early. I fixed this by deleting after a timeout, but this timeout probably should be made configurable.