Add a basic test for flavor validation #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itzikb-redhat
force-pushed
the
flavor-validations
branch
from
c18e9c4 to
9c17150
Compare
mdbooth
reviewed
Dec 9, 2024
Contributor
mdbooth
left a comment
mdbooth
left a comment
There was a problem hiding this comment.
Some nits, but as far as I'm concerned if the added tests pass and it passes make lint it's good to go 👌
test/apivalidations/common_test.go
Outdated
| ) | ||
|
|
||
| // Create a random string of length n | ||
| func generateResouceName(prefix string) string { |
Contributor
There was a problem hiding this comment.
You shouldn't need this, btw, as each test runs in its own namespace. (Also typo in the name, btw)
| obj.Name = generateResouceName(flavorPrefix) | ||
| obj.Namespace = namespace.Name | ||
| return obj | ||
| } |
Contributor
There was a problem hiding this comment.
nit: missing blank line below. Surprised go fmt didn't complain about that 🤔
itzikb-redhat
force-pushed
the
flavor-validations
branch
from
9c17150 to
ad210d0
Compare
Member
|
go-fmt should succeed after a rebase |
Check that a minimal flavor pass Check that a flavor without RAM or VCPUs or with value 0 fails Add validations for RAM and VCPUs to have a minimum Check that a flavor with a description greater than 1024 fails Move testCredentials to common_test
itzikb-redhat
force-pushed
the
flavor-validations
branch
from
ad210d0 to
73e3c1b
Compare
mdbooth
approved these changes
Dec 10, 2024
Contributor
mdbooth
left a comment
mdbooth
left a comment
There was a problem hiding this comment.
This looks great. Lets ship it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that a minimal flavor pass
Check that a flavor without RAM or VCPUs or with value 0 fails
Add validations for RAM and VCPUs to have a minimum
Check that a flavor with a description greater than 1024 fails
Move testCredentials to common_test