-
Notifications
You must be signed in to change notification settings - Fork 24
Add cast container routes to resolve issue #1553 #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: nexus
Are you sure you want to change the base?
Conversation
- Added three new routes for cast containers: - get_dbitem_movie_cast (ListGetMovieCast) - get_dbitem_tvshow_cast (ListGetTVShowCast) - get_dbitem_episode_cast (ListGetEpisodeCast) - Updated addon version from 2.1.34 to 2.1.35 - Updated dependency on script.module.jurialmunkey to v0.2.30 - Added comprehensive documentation in CAST_ROUTES.md with: - Route usage examples - ListItem properties reference - Skin XML examples - Troubleshooting guide This enables skinners to populate containers with cast information from Kodi's local database when using call_auto with add_dbid.
Add cast container routes to resolve issue #1553
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds three new container routes to script.skinvariables that enable skins to populate containers with cast information retrieved from Kodi's local database. This resolves issue #1553 by allowing cast data to be displayed when using TMDb Helper's call_auto feature with add_dbid.
Key Changes:
- Added three new cast retrieval routes:
get_dbitem_movie_cast,get_dbitem_tvshow_cast, andget_dbitem_episode_cast - Updated dependency requirement for script.module.jurialmunkey from v0.2.28 to v0.2.30
- Comprehensive documentation added in CAST_ROUTES.md with usage examples
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| resources/lib/plugin.py | Adds three new route definitions for movie, TV show, and episode cast retrieval, mapping to jurialmunkey.jrpcid module classes |
| addon.xml | Bumps addon version to 2.1.35 and updates script.module.jurialmunkey dependency to v0.2.30 |
| CAST_ROUTES.md | Provides comprehensive documentation for the new cast routes including API details, ListItem properties, XML examples, integration instructions, and troubleshooting guidance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </control> | ||
|
|
||
| <!-- Second cast member --> | ||
| <control type="label> |
Copilot
AI
Jan 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing double quote in the XML opening tag. The attribute 'type' should be properly quoted as 'type="label"' instead of 'type="label>'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
| </control> | ||
| <!-- Number of cast members --> | ||
| <control type="label> |
Copilot
AI
Jan 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing double quote in the XML opening tag. The attribute 'type' should be properly quoted as 'type="label"' instead of 'type="label>'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
| ```xml | ||
| <!-- First cast member --> | ||
| <control type="label> |
Copilot
AI
Jan 3, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing closing double quote in the XML opening tag. The attribute 'type' should be properly quoted as 'type="label"' instead of 'type="label>'.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot open a new pull request to apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file. Documentation should be done in the Wiki not as files.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
| ```xml | ||
| <!-- First cast member --> | ||
| <control type="label> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this file. Documentation should be done in the Wiki not as files.
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <addon id="script.skinvariables" | ||
| version="2.1.34" | ||
| version="2.1.35" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this version bump. Version bumps should be done as a separate commit when a release is made not when the code base changes.
Add cast container routes to resolve issue #1553
Cast Container Routes
Overview
Script.skinvariables now provides routes to populate containers with cast information from Kodi's local database. This addresses issue #1553 by enabling cast display when using
call_autowithadd_dbid.Available Routes
Movie Cast
Retrieves cast information for a movie by its database ID.
Route:
get_dbitem_movie_castURL Format:
Example:
TV Show Cast
Retrieves cast information for a TV show by its database ID.
Route:
get_dbitem_tvshow_castURL Format:
Example:
Episode Cast
Retrieves cast information for an episode by its database ID.
Route:
get_dbitem_episode_castURL Format:
Example:
Cast ListItem Properties
Each cast member in the container has the following properties:
LabelLabel2Art(thumb)Property(name)Property(role)Property(order)Property(index)Property(thumbnail)Skin XML Examples
Basic Cast List
Updating Cast Container on Info Dialog Open
Conditional Cast Display
Accessing Specific Cast Members
Integration with TMDb Helper
When using with plugin.video.themoviedb.helper's
call_autofeature:The cast container will now be properly populated when the info dialog opens, thanks to the new cast routes.
Requirements
Notes
Troubleshooting
Container not populating:
Thumbnails not showing:
Wrong cast information:
infoparameter is used (movie_cast vs tvshow_cast vs episode_cast)Related Issues
Changelog
v2.1.35
get_dbitem_movie_castrouteget_dbitem_tvshow_castrouteget_dbitem_episode_castroute