feat(cli-tools): allow deployment of 0kb files#843
Open
peterpeterparker wants to merge 1 commit intomainfrom
Open
feat(cli-tools): allow deployment of 0kb files#843peterpeterparker wants to merge 1 commit intomainfrom
peterpeterparker wants to merge 1 commit intomainfrom
Conversation
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We actually need to allows deployment of 0kb files because Vite v8 starts generating that kind of chunks. Likely a bug on their hand but, to some extension, nothing - both in terms of certification or serving empty content regardless of the encoding - prevents a Satellite or Console to deliver that type of content.
Therefore we can start supporting empty.
In the future, if anyone has the need, maybe we can add a rule to the cli to skip files that are smaller than x bytes for example.
Relates to junobuild/juno#2695