Skip to content

fix: addons npm tools (icp-bindgen) must be available at runtime #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peterpeterparker merged 3 commits into from
Nov 25, 2025
Merged

fix: addons npm tools (icp-bindgen) must be available at runtime #64

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40d7647
fix: addons npm tools (icp-bindgen) must be available at runtime
peterpeterparker Nov 25, 2025
71cde2d
feat: copy not needed anymore
peterpeterparker Nov 25, 2025
966459d
feat: but copy here
peterpeterparker Nov 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 4 additions & 8 deletions Dockerfile.full
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,20 +38,12 @@ ENV RUSTUP_HOME=/home/apprunner/.rustup \
CARGO_HOME=/home/apprunner/.cargo \
PATH=/home/apprunner/.cargo/bin:$PATH

# Configure npm to install globally to user directory
ENV NPM_CONFIG_PREFIX=/home/apprunner/.npm-global \
PATH=/home/apprunner/.npm-global/bin:$PATH

# Copy list of scripts to run setup
COPY --chown=apprunner:apprunner ./kit/setup/bootstrap ./kit/setup/bootstrap
COPY --chown=apprunner:apprunner ./kit/setup/addons ./kit/setup/addons

# Install core tools required for building WASM (same as in the main Juno repository)
RUN ./kit/setup/bootstrap

# Install extra WASM build tools needed only for this GitHub Action
RUN ./kit/setup/addons

# --- Runtime Stage ---
FROM node:24-slim@sha256:76d0ed0ed93bed4f4376211e9d8fddac4d8b3fbdb54cc45955696001a3c91152

Expand Down Expand Up @@ -79,6 +71,10 @@ RUN DEBIAN_FRONTEND=noninteractive apt update && apt install -y \
COPY ./kit/setup/tools ./kit/setup/tools
RUN ./kit/setup/tools

# Install extra WASM build tools - e.g. for Sputnik - required by the GitHub Action runtime
COPY ./kit/setup/addons ./kit/setup/addons
RUN ./kit/setup/addons

# Create and use a user instead of using root
RUN useradd -ms /bin/bash apprunner
USER apprunner
Expand Down