Skip to content

Conversation

@mangelajo
Copy link
Member

@mangelajo mangelajo commented Jan 16, 2026

Fixes-Issue: #800

Summary by CodeRabbit

  • Bug Fixes
    • Removed automatic terminal screen clearing when closing console connections.

✏️ Tip: You can customize this high-level summary in your review settings.

@netlify
Copy link

netlify bot commented Jan 16, 2026

Deploy Preview for jumpstarter-docs ready!

Name Link
🔨 Latest commit cd9930c
🔍 Latest deploy log https://app.netlify.com/projects/jumpstarter-docs/deploys/696a6f55f7906100088cd99e
😎 Deploy Preview https://deploy-preview-804--jumpstarter-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 16, 2026

📝 Walkthrough

Walkthrough

Both the BLE and PySerial driver console implementations remove terminal clear-and-reset escape sequences from the setraw finally blocks. The terminal attribute restoration logic remains unchanged; only the ANSI escape sequence print statements are eliminated.

Changes

Cohort / File(s) Summary
Terminal cleanup removal
packages/jumpstarter-driver-ble/jumpstarter_driver_ble/console.py, packages/jumpstarter-driver-pyserial/jumpstarter_driver_pyserial/console.py
Removed escape sequence prints (screen clear and cursor home) from setraw finally blocks in both BLE and PySerial console implementations, leaving only terminal attribute restoration

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

Poem

🐰 No more screen flickers when the rabbit hops away,
Clean escapes in sight, a tidier display!
Terminal resets fall, but restoration stays,
Simpler setraw journeys through our coding days! ✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the console reset/clear sequence on exit from both BleConsole and Console classes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings


📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 595a7fa and cd9930c.

📒 Files selected for processing (2)
  • packages/jumpstarter-driver-ble/jumpstarter_driver_ble/console.py
  • packages/jumpstarter-driver-pyserial/jumpstarter_driver_pyserial/console.py
💤 Files with no reviewable changes (2)
  • packages/jumpstarter-driver-ble/jumpstarter_driver_ble/console.py
  • packages/jumpstarter-driver-pyserial/jumpstarter_driver_pyserial/console.py
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
  • GitHub Check: Redirect rules - jumpstarter-docs
  • GitHub Check: Header rules - jumpstarter-docs
  • GitHub Check: Pages changed - jumpstarter-docs
  • GitHub Check: e2e
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.13)
  • GitHub Check: pytest-matrix (macos-15, 3.13)
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.11)
  • GitHub Check: pytest-matrix (ubuntu-24.04, 3.12)
  • GitHub Check: pytest-matrix (macos-15, 3.11)
  • GitHub Check: build
  • GitHub Check: pytest-matrix (macos-15, 3.12)

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants