fix(hooks): display WARNING to client when hook fails with onFailure: warn#442
Open
ambient-code[bot] wants to merge 1 commit intomainfrom
Open
fix(hooks): display WARNING to client when hook fails with onFailure: warn#442ambient-code[bot] wants to merge 1 commit intomainfrom
ambient-code[bot] wants to merge 1 commit intomainfrom
Conversation
…ibility When a hook fails with onFailure: warn, the WARNING log from _handle_hook_failure was emitted outside the context_log_source context manager, causing it to be tagged with SYSTEM source instead of the hook source. This made the warning invisible to clients without --exporter-logs since only hook-sourced logs are shown by default. Move the failure handling inside context_log_source so the WARNING is tagged with BEFORE_LEASE_HOOK / AFTER_LEASE_HOOK and always visible. Fixes #246 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onFailure: warn(the default), the WARNING log from_handle_hook_failurewas emitted outside thecontext_log_sourcecontext manager, causing it to be tagged withSYSTEMsource instead of the hook source (BEFORE_LEASE_HOOK/AFTER_LEASE_HOOK)--exporter-logs), the warning was invisiblecontext_log_sourceso the WARNING log is correctly tagged and always visible to the clientFixes #246
Test plan
make lint-fix)🤖 Generated with Claude Code