fix: preserve URL query parameters in storage flash for signed URLs#435
fix: preserve URL query parameters in storage flash for signed URLs#435ambient-code[bot] wants to merge 2 commits intomainfrom
Conversation
URLs with query parameters (e.g. CloudFront signed URLs with ?Expires=...&Signature=...&Key-Pair-Id=...) were being silently stripped during URL parsing, causing the download to receive an error/empty response instead of the actual image. Fixes #271 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Deploy Preview for jumpstarter-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@ambient-code CI is failing here, can you check? |
|
@ambient-code handle comments |
On macOS, /tmp is a symlink to /private/tmp, so Path.resolve() returns /private/tmp/... instead of /tmp/.... Compare against the resolved path to make the test pass on both Linux and macOS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
CI Fix PushedRoot cause: The Fix (0e5b701): Changed the filesystem path assertion to compare against Other failing jobs:
No unaddressed review comments — only bot comments from CodeRabbit and Netlify were present. |
Summary
operator_for_path()to preserve URL query parameters (e.g.?Expires=...&Signature=...&Key-Pair-Id=...) when creating OpenDAL HTTP operators, so signed URLs are fetched correctlyflash()to similarly preserve query params_filename(),_get_decompression_command(), and_transfer_bg_thread()to properly strip query parameters when extracting filenames for storage and compression detectionFixes #271
Test plan
operator_for_pathwith query params_filenamewith query params_get_decompression_commandwith query params🤖 Generated with Claude Code