Skip to content

Conversation

@bkhizgiy
Copy link

@bkhizgiy bkhizgiy commented Jan 19, 2026

Replace the single selector field with a oneof exporter_selection, allowing leases to target either exporters via label selector or a specific device by resource name.
Both options are immutable to preserve lease semantics.

The field is no longer marked as REQUIRED, as the controller now validates whether a value was provided.

Issue: jumpstarter-dev/jumpstarter#638
Related to: jumpstarter-dev/jumpstarter-controller#208

Signed-off-by: Bella Khizgiyaev <bkhizgiy@redhat.com>
@coderabbitai
Copy link

coderabbitai bot commented Jan 19, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant