Skip to content
This repository was archived by the owner on Jan 23, 2026. It is now read-only.
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions internal/controller/lease_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1660,20 +1660,22 @@ var _ = Describe("Scheduled Leases", func() {
It("should acquire first lease at BeginTime, then second after first is released", func() {
ctx := context.Background()

// Use same BeginTime for both to avoid timing races
sharedBeginTime := metav1.NewTime(time.Now().Truncate(time.Second).Add(1 * time.Second))
// Give lease1 an earlier BeginTime to ensure deterministic ordering
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the controller is non deterministic when two leases share begin time.

// Stagger them closely so both BeginTimes will have passed by the time we check lease2
lease1BeginTime := metav1.NewTime(time.Now().Truncate(time.Second).Add(1 * time.Second))
lease2BeginTime := metav1.NewTime(time.Now().Truncate(time.Second).Add(1*time.Second + 100*time.Millisecond))

// Both leases target dut:b (only one exporter available)
lease1 := leaseDutA2Sec.DeepCopy()
lease1.Name = lease1Name
lease1.Spec.Selector.MatchLabels["dut"] = "b"
lease1.Spec.BeginTime = &sharedBeginTime
lease1.Spec.BeginTime = &lease1BeginTime
lease1.Spec.Duration = &metav1.Duration{Duration: 10 * time.Second} // Long duration, but we'll release early

lease2 := leaseDutA2Sec.DeepCopy()
lease2.Name = lease2Name
lease2.Spec.Selector.MatchLabels["dut"] = "b"
lease2.Spec.BeginTime = &sharedBeginTime
lease2.Spec.BeginTime = &lease2BeginTime
lease2.Spec.Duration = &metav1.Duration{Duration: 10 * time.Second}

Expect(k8sClient.Create(ctx, lease1)).To(Succeed())
Expand Down
Loading