Conversation
ffd9eaf to
800dae2
Compare
|
This is consistent with ParametricOptInterface which does some magic if it takes an optimizer constructor as argument but when it takes an instantiated optimizer, it does not modify it. |
|
Interesting, |
Yes, I think we should discuss this, and it should also go in parallel with the layer design that @odow suggested in |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #209 +/- ##
=======================================
Coverage 94.47% 94.47%
=======================================
Files 14 14
Lines 742 742
=======================================
Hits 701 701
Misses 41 41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
It's a bit counter intuitive to still add caches and bridges when the user explicitly give an instantiated model. I guess the use case is the
DualizableModelbut maybe we don't need this. We're using aUniversalFallbackon top of it anyway so what's the use for it instead of justMOI.Utilities.Model?