Enable selection handler property to be populated via selection-model-handle-events attribute#48
Open
avassilev-odbg wants to merge 5 commits intojtrussell:masterfrom
Open
Enable selection handler property to be populated via selection-model-handle-events attribute#48avassilev-odbg wants to merge 5 commits intojtrussell:masterfrom
avassilev-odbg wants to merge 5 commits intojtrussell:masterfrom
Conversation
…-handle-events attribute
Owner
|
This seems like a useful feature. I'd love to add it but would you mind including some tests? Also, I might be wrong but I think the events should maybe be space separated instead of comma separated? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
We need this update in order to trigger selection on different events.
With this change you can specify them in the 'selection-model-handle-events' attribute.
It is evaluated by the selectionModel directive.
Example:
<li data-ng-repeat="child in parent" data-selection-model data-selection-model-handle-events="'click mousedown'" ></li>Notes:
The attribute value is evaluated by the directive, so you need to specify it in single quotes for strings or provide a getter function.