fix top-level resource optional id & add test cases for type/id requirements#13
Open
nruth wants to merge 1 commit intojsonapi-rb:masterfrom
Open
fix top-level resource optional id & add test cases for type/id requirements#13nruth wants to merge 1 commit intojsonapi-rb:masterfrom
nruth wants to merge 1 commit intojsonapi-rb:masterfrom
Conversation
on client requesting to create a resource on the server
Codecov Report
@@ Coverage Diff @@
## master #13 +/- ##
==========================================
+ Coverage 80.67% 81.51% +0.84%
==========================================
Files 5 5
Lines 119 119
==========================================
+ Hits 96 97 +1
+ Misses 23 22 -1
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
on client requesting to create a resource on the server
This happened after seeing jsonapi-rb/jsonapi-deserializable#21 and trying to figure out whether I can use that or not (after having false starts with a lot of ruby json-api libraries).
The code was already structured to handle the optional top-level id, it just seems be wired up wrong and was missing a test case. This will need a review as I'm not 100% sure of what the spec says, especially about the case where the top-level is an array of resource objects rather than a single one. I think this makes sense, but it might be wrong.