Add fix for issue #357 - strick parsing of null, true and false keywords #367
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d false keywords
Author
Author
|
Hey @taowen / @elifarley / @based2 / @plokhotnyuk, can someone review and approve my MR? Thanks in advance. |
Author
|
Hi @plokhotnyuk / @taowen / @based2 / @elifarley, following up on my MR which is on back of issue #357 . Could you please check and approve the MR? thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enforces strict JSON parsing for the
null,true, andfalsekeywords.It fixes cases where the parser would accept invalid literals such as
"nope","t123", or"fxxxx"by reading the first token and blindly skipping the remainingbytes using
skipFixedBytes().The change updates
readNull()andreadBoolean()to validate exact keyword bytesand fixes their usage across switch cases to avoid partial or incorrect matches.