Skip to content

Conversation

@JannikSt
Copy link
Contributor

Summary

Updated the type annotation for the verify parameter in the Requester class to support both boolean values and string paths to CA certificates (Union[bool, str]). This aligns with the Python requests library's verification parameter and enables proper mTLS setup with custom CA certificates as documented in Nomad's TLS configuration guide.

Details

  • Changed verify parameter type from bool to Union[bool, str]
  • Maintains backward compatibility with boolean values
  • Enables specifying custom CA certificate paths for TLS verification
  • Follows the same pattern as the requests library's verify parameter

@codecov
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.67%. Comparing base (41df869) to head (55286a8).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   90.71%   90.67%   -0.05%     
==========================================
  Files          31       31              
  Lines        1293     1297       +4     
==========================================
+ Hits         1173     1176       +3     
- Misses        120      121       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nikita-b
Copy link
Collaborator

nikita-b commented Jan 30, 2025

@JannikSt Hello,

Thanks for your contribution!
Could you please rebase from master branch and fix linter, please?

@JannikSt JannikSt force-pushed the improvement/requester-verify-typing branch from e197b8a to bbb3782 Compare May 1, 2025 03:41
@JannikSt
Copy link
Contributor Author

JannikSt commented May 1, 2025

@JannikSt Hello,

Thanks for your contribution! Could you please rebase from master branch and fix linter, please?

Hey @nikita-b - greetings from SF.
Done

@nikita-b nikita-b self-requested a review May 1, 2025 20:12
@nikita-b nikita-b merged commit 45c4773 into jrxFive:master May 1, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants