Tweaks to WASM-based build for JVM #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
org.jruby:chicory-prism
Nodes need access to RubySymbol and support APIs at least.
* It is a resource used as source code (in wasm) that is compiled for the project artifact. * Added to Rake CLOBBER
andreaTP
reviewed
Jan 23, 2026
| with: | ||
| name: prism.wasm | ||
| path: java-wasm/src/test/resources/prism.wasm | ||
| path: java-wasm/src/main/resources/prism.wasm |
There was a problem hiding this comment.
The prism.wasm file was very intentionally placed in test so that it doesn't get included in the resulting jar (it's redundant).
The Chicory compiler already generates a org/prism/PrismParser.meta file that is smaller and contains everything needed for execution.
| instance = Instance.builder(module) | ||
| .withMemoryFactory(limits -> new ByteArrayMemory(new MemoryLimits(10, MemoryLimits.MAX_PAGES))) | ||
| .withMachineFactory(PrismModule::create) | ||
| .withMachineFactory(parser.machineFactory()) |
There was a problem hiding this comment.
nit: .withMachineFactory(PrismParser::create)
| @@ -1,11 +1,12 @@ | |||
| package org.prism; | |||
There was a problem hiding this comment.
Not a big deal, but you might want to align the package name to the new groupId.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bit of cleanup and documentation here mostly.
org.jruby.chicory-prism.RubySymbol.java-wasmbuild output tojava-wasm/src/main/resources.