Skip to content

Some improvements I made. #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BrettRyland wants to merge 277 commits into
base: master
Choose a base branch
from
Open

Some improvements I made. #5

BrettRyland wants to merge 277 commits into from

Conversation

@BrettRyland
Copy link

@BrettRyland BrettRyland commented Nov 16, 2020 •
edited
Loading

Assuming you're still maintaining this, here's a few improvements.

  • Fix the epilepsy inducing shaking when the targeted vessel dies.
  • Adjustable lerp rate in the settings.
  • Lerp from previous position/orientation instead of resetting (due to the camera transform parent being set to null) in dogfight mode.
  • Various small tweaks.
  • Organisation of the code with #region #endregion tags.
  • Auto-enable option for BDArmory competition.

Not done yet:

  • Avoid stationary camera angles that are under ground/water for flying targets or really far away.

@BrettRyland
Copy link
Author

BrettRyland commented Feb 25, 2021

Hey @jrodrigv, any chance you could merge this soon and make a new release. The only people benefiting from the improved DLL are those on the RWP/Munway/FC discord servers whom happened to pick up the DLL when I posted it there.

BrettRyland and others added 27 commits March 4, 2021 21:18
@BrettRyland
Smoother transitions and avoid jitter when switching targets and vess…
8e18361 
…els.
@BrettRyland
Remove noDogfightTargetTimer as it doesn't seem to trigger now.
c84ca0d
@BrettRyland
Reduce flickering by compensating for floating origin changes. Add on…
f9e33db 
…-screen debugging.
@BrettRyland
Correct grouping of debugging checks.
37b3262
@BrettRyland
Fix NRE in atmospheric audio when vessel is destroyed.
37693e2
@BrettRyland
Add roll parameter to dogfight camera.
8e065ac
@BrettRyland
Update changelog and bump version number.
bf50d48
@BrettRyland
Fix missing config file load/save bug.
7a067d7
@BrettRyland
Update changelog and version number.
7449ca2
@BrettRyland
Don't touch camera when we're not in control of it. Use TimeWarp inst…
28398c9 
…ead of Time for velocity calculations. Allow switching into and out of IVA and Map modes without breaking.
@BrettRyland
Change the keypad move/zoom speeds to sliders for easier access. Disa…
949459a 
…ble slider discretisation when keypad control is enabled.
@BrettRyland
Properly correct for time-warp under almost all conditions for dogfig…
aa9458e 
…ht mode.
@josuenos
Merge pull request #6 from BrettRyland/master
18e8505 
Master
@BrettRyland
Add some more debugging.
2a40665
@BrettRyland
Adjust DEBUG2 output
54eece2
@BrettRyland
Migrate non-static config files to PluginData to avoid invalidating t…
9284f32 
…he ModuleManager cache (should give slightly faster start-up times). Exclude music volume levels from volumes based on distance from the camera. Adjust DEBUG2 debugging statements.
@BrettRyland
Update changelog, bump version number.
af90568
@BrettRyland
Try to reacquire a dogfight target if reverted due to a null dogfight…
a92cef7 
… target and Auto-Enable for BDArmory is enabled. Limit the type of vessels atmospheric audio gets added to to avoid saturating KSP's SoundManager channels unnecessarily.
@BrettRyland
Add sliders for configuring chances of 'random mode'. Add IVA view. F…
02c50cf 
…ix indexing bug in 'pathing mode' (note: the example path is still weird).
@BrettRyland
Changelog and spelling.
483e27c
@BrettRyland
Improve the positioning of the Stationary Camera when the target is c…
852230f 
…lose to the ground or about to crash.
@BrettRyland
Don't restart camera on flight mode change when spawning.
024ef09
@BrettRyland
Bump version number
f155a54
@BrettRyland
Fix NRE when vessel is destroyed before switching to IVA mode. Don't …
c7c4097 
…immediately re-enter IVA mode if manually switched out of it.
@BrettRyland
Update the version number
ec1bde8
@BrettRyland
Cached engine modules to avoid frequent GC allocations.
f13785a
@BrettRyland
Trigger random mode selection on manual activation when random mode i…
63d0699 
…s on. Exit IVA mode more reliably. Optimisations to avoid GC allocations.
BrettRyland added 30 commits June 7, 2024 14:41
@BrettRyland
Add a slider for selecting the reference frame to use for the dogfigh…
91d0ff9 
…t offset.
@BrettRyland
Adjust the dogfight inertial chase slider to the range 0—1 and adjust…
cf58bc6 
… the 'inertia' behaviour, including affecting camera rotation.
@BrettRyland
Don't switch modes on vessel switch if random mode is not enabled.
428dd42
@BrettRyland
Fix the unintended roll due to lerping. Add chase-plane mode. Lerp th…
0a8fc62 
…e roll in inertial and chase-plane modes. .transform optimisations.
@BrettRyland
Add option to choose which part the chase plane mode tracks.
e906996
@BrettRyland
Add controller input (AXIS_CAMERA_HDG and AXIS_CAMERA_PITCH) to freel…
1f1a2f1 
…ook in dogfight mode and camera rotation in stationary and pathing modes.
@BrettRyland
Add a geospatial pathing option to pathing mode where points are GPS …
9ed5dd9 
…coordinates and rotations are absolute instead of relative to the active vessel.
@BrettRyland
Bump version number for release.
c21969b
@BrettRyland
Add a UI scaling option that is tied to the global UI_SCALE setting b…
4a7f89a 
…y default.
@BrettRyland
Tweak some debugging.
6e62f05
@BrettRyland
Bump version numbers for release.
91e90a0
@BrettRyland
Add in a missing Krakensbane correction for the dogfight inertial cha…
cf31c9e 
…se camera rotation target.
@BrettRyland
Bump version numbers for bugfix release.
3900422
@BrettRyland
Use vessel.ReferenceTransform instead of vessel.transform in the dogf…
35c3470 
…ight camera for when the controlling part isn't the root part and may have a different orientation.
@BrettRyland
Fall back to the regular vessel.transform in case the reference trans…
07c310d 
…form is null.
@BrettRyland
Use vessel.vesselTransform as the fallback and update it each frame i…
f05e03c 
…n case the reference transform becomes null due to lost parts. Do the same for the stationary camera.
@BrettRyland
Update changelog
cc4f7a0
@BrettRyland
Bump version numbers for bugfix release.
123d7f4
@BrettRyland
Reset lerp momentum for the dogfight inertial chase mode when startin…
c702d33 
…g the dogfight camera.
@BrettRyland
Revert to pivoting around the camera in stationary mode if in target-…
0d38d6d 
…pivot mode and there's no target to pivot around.
@BrettRyland
Move random mode overrides into ChooseRandomMode so that it's usable …
c91a16a 
…by other callers. Respect random mode when auto-starting for BDA.
@BrettRyland
Adjust autoFlyBy/randomMode offsets in stationary camera to account f…
278c81a 
…or vessel size.
@BrettRyland
Include vessel radius when checking the random mode override.
0151c8c
@BrettRyland
Add changelog entries.
5665ba9
@BrettRyland
Use vessel.transform.position instead of vessel.CoM for checking LoS …
9e45ba1 
…from the initial stationary camera position due to weird parts allowing the CoM to be below terrain.
@BrettRyland
Bump version for release
452cbe9
@BrettRyland
Minor layout tweaks to account for strings being clipped for some UI …
035eafd 
…scaling values.
@BrettRyland
Include the UI scaling for the tooltip position (can't adjust size th…
f41bb23 
…ough).
@BrettRyland
Compatibility fixes with pre-KSP v1.12 versions.
1541a9e
@BrettRyland
Add some changelog entries and bump the version number for a bugfix r…
f1e6f4d 
…elease.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BrettRyland @videopilot @ac1mx @josuenos @Halbann @SuicidalInsanity @ThreeMACH