jquery: Update Twitter to x#488
Closed
HermitAssociation wants to merge 5 commits into
Closed
Conversation
timmywil
requested changes
Feb 20, 2026
Member
timmywil
left a comment
timmywil
left a comment
There was a problem hiding this comment.
Thank you for this! While you're making changes here, could you add a link to jQuery's mastodon? https://social.lfx.dev/@jquery
| font-family: "FontAwesome"; | ||
| src: url("../lib/FontAwesome/fontawesome-webfont.woff2") format("woff2"), | ||
| url("../lib/FontAwesome/fontawesome-webfont.woff") format("woff"); | ||
| src: url("../lib/FontAwesome/fa-brands-400.woff2") format("woff2"); |
Member
There was a problem hiding this comment.
I'd like to keep woff in there as well. We still get some traffic from early IE versions and technically jQuery 4.0 still supports IE11.
Contributor
Author
There was a problem hiding this comment.
Oh, I think that should be fine. I just noticed that issue #455 mentions changing FontAwesome to SVG icons. I plan to launch a new pull later using SVG instead of FontAwesome.
| * Original Font Awesome 3.0.2 by Dave Gandy | ||
| * Email: dave@fontawesome.io | ||
| * Twitter: http://twitter.com/davegandy | ||
| */ No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Twitter was renamed to X back in March 2023. This draft attempts to update the jQuery site's Twitter account to X, including the icon and link.
Since jQuery uses Font Awesome 3.0.2, which does not include the x-twitter icon and is only supported in the latest 7.x version, I tried upgrading jQuery's Font Awesome from 3.0.2 to 7.2.0. Upon updating to version 7.2.0, I discovered that some icons had been removed or their Unicode had changed, and I updated accordingly.
The updated icon style is as follows:
footer(new):
footer(old):
learn(new):
learn(old):