Skip to content

Conversation

@ascheman
Copy link

By default, only open PullRequests are retrieved by the API, but usually one wants to get ALL into the jQA DB.

I also dropped the branch from the PR retrieval as it does not make sense by my understanding.
Perhaps @StephanPirnbaum as the main author has some background why it was initially added?

By default, the GH API only retrieves open PRs.
The branch has no meaning when retrieving issues and PRs.
@DirkMahler DirkMahler merged commit 6e52332 into jqassistant-plugin:master Mar 20, 2025
5 checks passed
@ascheman ascheman deleted the bugfix/prs-incomplete branch March 20, 2025 10:11
@StephanPirnbaum
Copy link

@ascheman Thank you for the contribution.

The limitation was in place to limit the load and number of imported data. This was fine in the use case fo which the plugin was originally implemented. I see the need, however, to retrieve all and and also not limited to a specific base branch.

@DirkMahler @ascheman Could you please provide another PR to make this behaviour configurable?

@ascheman
Copy link
Author

The limitation was in place to limit the load and number of imported data. This was fine in the use case fo which the plugin > was originally implemented. I see the need, however, to retrieve all and and also not limited to a specific base branch.

Thanks for the feedback, @StephanPirnbaum , I hope I will not run into such issues. But for clarification: Are PRs bound to a particular branch (or would it make sense to restrict them by branch)? I guess most PRs are directed towards the default branch (though there might be also other target branches)?

@DirkMahler @ascheman Could you please provide another PR to make this behaviour configurable?

To be honest, I do not yet have any idea how to do that?
BTW: Shouldn't we open a new issue instead of discussing this in the already closed PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants