Open
Conversation
added 2 commits
August 10, 2015 16:44
The setMedia call will need to provide a mpdv key pointing to a mdp (Media Presentation Description) file. You also need to require dash.js[1] before initializing jPlayer. [1] https://github.com/Dash-Industry-Forum/dash.js
The dash.all.js file on the official dashjs.org cdn is version 1.4 which is 2 months old and has a bug which breaks playback in Safari on Yosemite. This commit replaces it with a freshly compiled version I created from the development branch of the dash.js project as of commit 8b045c757.
thepag
reviewed
Mar 18, 2017
Contributor
thepag
left a comment
thepag
left a comment
There was a problem hiding this comment.
Looks good... We used to merge into the dev branch and then to master when a release was made, but it looks like the master branch is already ahead of develop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added support for MPEG-DASH streaming.
To use it, you include a 'mpdv' file in your setMedia call as well as adding mpdv to the 'supplied' string. Mpeg Dash will be used if the browser supports it (MediaSource extensions are available), and the dash.js library is available.
There is an existing feature request for this (issue #304 )