Closed
Conversation
added 2 commits
July 11, 2014 20:07
Conflicts: add-on/jplayer.playlist.js
Contributor
|
This is generic notification that all users issuing pull requests must sign our CLA before we can consider merging with the jPlayer project. I did take a brief look and there is a new HTML5 download attribute, that seems to do the job very well. While older browsers may need to continue with the right click to download, modern browsers will deal with it for us. So atm I do not plan to merge this PR. We appreciate the PR though 😄 |
Contributor
|
Just reviewed... I will be going with the other solution that will work in HTML5 described in #254 The download attribute has reasonable support and this will only get better. It will also allow use to do something more like: <a href="/media/hdgs-6bsf.mp3" download="the-scientist.mp3">The Scientist</a>Thank you for the suggestion. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for two new options for download links (.jp-playlist-item-free), namely a prefix that is added before the link (
downloadPrefix) and the ability to disable the "force right click" handler (downloadForceRightClick).I use this to redirect the links to a server-side script that changes a few headers to allow left-click download of files.