Implement Autohide for Mobile/Touch Devices#158
Open
GregKass wants to merge 1 commit intojplayer:masterfrom
Open
Implement Autohide for Mobile/Touch Devices#158GregKass wants to merge 1 commit intojplayer:masterfrom
GregKass wants to merge 1 commit intojplayer:masterfrom
Conversation
A touch on the videoplayer fades in the player controls, over 'fadeIn' milliseconds. When the touch is released, after 'hold' milliseconds, the controls fade out after 'fadeOut' milliseconds, unless the player or controls are retouched, in which case the 'hold' countdown resets until next touch release. I copied the conditional checks for autohide into the event handlers. This satisfies the need to not autohide the controls on video end and on video pause, for example. Many video players, particularly for entertainment content, keep the controls shown on end and on pause. I have not tested fully if having the conditionals here negates the need for the same conditional on line 2262.
Contributor
|
This is generic notification that all users issuing pull requests must sign our CLA before we can consider merging with the jPlayer project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A touch on the videoplayer fades in the player controls, over 'fadeIn' milliseconds.
When the touch is released, after 'hold' milliseconds, the controls fade out after 'fadeOut' milliseconds, unless the player or controls are retouched, in which case the 'hold' countdown resets until next touch release.
I copied the conditional checks for autohide into the event handlers. This satisfies the need to not autohide the controls on video end and on video pause, for example. Many video players, particularly for entertainment content, keep the controls shown on end and on pause. I have not tested fully if having the conditionals here negates the need for the same conditional on line 2262.