fix: apply Deno formatting#2
Open
taras wants to merge 1 commit intojoshamaju:effect-benchmarkfrom
Open
Conversation
Run deno fmt to fix formatting issues that were causing CI to fail. The original code was formatted with Prettier instead of Deno's formatter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the CI formatting failures on your Effect benchmark PR (thefrontside#981 on thefrontside/effection).
Changes
Just 3 files formatted with
deno fmt:tasks/bench.ts- trailing comma fixtasks/bench/scenarios/effect.recursion.ts- line break styletasks/bench/scenarios/scenario.ts- ternary formattingRoot Cause
The code was formatted with Prettier instead of Deno's built-in formatter, causing
deno fmt --checkto fail in CI.After Merging
Once you merge this, your PR thefrontside#981 should pass the formatting check. Note that there's still a lint issue (
tasks/is now excluded from linting in the current v4 branch), so you may also need to rebase onto the latest v4 to pass CI fully.Thanks for the Effect benchmark contribution!