Introduce Color value object across wallet builders and Pass models#3
Draft
Korbeil wants to merge 1 commit intofeature/update-google-spec-20260409from
Draft
Introduce Color value object across wallet builders and Pass models#3Korbeil wants to merge 1 commit intofeature/update-google-spec-20260409from
Korbeil wants to merge 1 commit intofeature/update-google-spec-20260409from
Conversation
2e83352 to
06a75bd
Compare
06a75bd to
e050aa4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change replaces ad-hoc color handling with a small, validated
Colorvalue object and threads it through shared builder state and all supported wallet platforms.What changed
Jolicode\WalletKit\Common\Colorwith factories for RGB components,#rrggbbhex, andrgb(r, g, b)strings, plusrgb()andhex()serializers; invalid input throwsInvalidColorException.CommonWalletStateand wallet builders so background, foreground, and label colors are typed asColorinstead of strings.ColorMapperin favor of the unifiedColorAPI.Testing
Extended or updated normalizer and builder tests; added coverage for
Colorbehavior.