Skip to content

Fix bad branch prediction #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrabine merged 1 commit into from
Mar 28, 2026
Merged

Fix bad branch prediction #182

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .clang-format
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ BraceWrapping:
AfterNamespace: true
AfterStruct: true
AfterUnion: true
AfterCaseLabel: true
BeforeCatch: true
BeforeElse: true
BeforeLambdaBody: false
BeforeWhile: true

# --- Spaces ---
SpaceBeforeParens: Always
Expand All @@ -48,6 +50,7 @@ AlignConsecutiveDeclarations: false

# --- Switch/Case ---
IndentCaseLabels: true
IndentCaseBlocks: true

# --- Strict Vertical Layout ---
AllowShortFunctionsOnASingleLine: None
Expand Down
10 changes: 5 additions & 5 deletions core/src/reactor.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ int Reactor::addHandler (int fd, EventHandler* handler, bool sync) noexcept
std::atomic<bool> done{false}, *pdone = nullptr;
std::atomic<int> errc{0}, *perrc = nullptr;

if (JOIN_UNLIKELY (sync))
if (JOIN_LIKELY (sync))
{
pdone = &done;
perrc = &errc;
Expand All @@ -124,7 +124,7 @@ int Reactor::addHandler (int fd, EventHandler* handler, bool sync) noexcept
return -1;
}

if (JOIN_UNLIKELY (sync))
if (JOIN_LIKELY (sync))
{
Backoff backoff;
while (!done.load (std::memory_order_acquire))
Expand Down Expand Up @@ -163,7 +163,7 @@ int Reactor::delHandler (int fd, bool sync) noexcept
std::atomic<bool> done{false}, *pdone = nullptr;
std::atomic<int> errc{0}, *perrc = nullptr;

if (JOIN_UNLIKELY (sync))
if (JOIN_LIKELY (sync))
{
pdone = &done;
perrc = &errc;
Expand All @@ -174,7 +174,7 @@ int Reactor::delHandler (int fd, bool sync) noexcept
return -1;
}

if (JOIN_UNLIKELY (sync))
if (JOIN_LIKELY (sync))
{
Backoff backoff;
while (!done.load (std::memory_order_acquire))
Expand Down Expand Up @@ -222,7 +222,7 @@ void Reactor::stop (bool sync) noexcept

writeCommand ({CommandType::Stop, -1, nullptr, nullptr, nullptr});

if (JOIN_UNLIKELY (sync))
if (JOIN_LIKELY (sync))
{
Backoff backoff;
while (_threadId.load (std::memory_order_acquire) != 0)
Expand Down
3 changes: 2 additions & 1 deletion services/include/join/httpserver.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,7 +418,8 @@ namespace join

this->writeResponse ();
this->cleanUp ();
} while ((this->_max < 0) || (--this->_max != 0));
}
while ((this->_max < 0) || (--this->_max != 0));

this->endRequest ();
}
Expand Down
Loading