Fix ICP client wiring and missing deployment exports#44
Open
johnnyclem wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
createICPClientpreviously required anHttpAgentwhile callers passed only a config, causing invalid client construction and broken deployment flow.validateWasmPathandcalculateWasmHashwere referenced as standalone imports but only existed as instance methods, preventing reuse by the deployer.generateStubCanisterIdwas exported from the barrel but not implemented, making the deployment index export incorrect.Description
ICPClientto accept only anICPClientConfigand changedcreateICPClienttocreateICPClient(config)to align construction across call sites (file:src/deployment/icpClient.ts).validateWasmPath,calculateWasmHash, andgenerateStubCanisterId, and refactored the instance methodsvalidateWasmPathandcalculateWasmHashto delegate to these helpers (file:src/deployment/icpClient.ts).deployAgentandgetCanisterStatusare valid (affectssrc/deployment/deployer.tsandsrc/deployment/index.ts).Testing
Codex Task