bugfix! fails on some videos#1
Open
np1 wants to merge 1 commit into
Open
Conversation
which fixes the program to work with non embeddable videos such as http://www.youtube.com/watch?v=dQw4w9WgXcQ
Owner
|
Thanks ! I did not find this issue. Actually it's just my python practice. So i didn't optimise it. there are still dozens of issues within the code, like downloading the different quality videos or downloading via proxy. Anyway, thanks for your participation and hope this code gives you help and fun ! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a couple of url parameters to the get_video_info url which fixes the program to work with non embeddable youtube videos such as
http://www.youtube.com/watch?v=dQw4w9WgXcQ and other vevo/youtube partner videos