Skip to content

Allows for default values #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eigenmannmartin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allows for default values #18

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
207249c
feat() allows for default values
Sep 3, 2020
b375910
fix: allow definition of more than one default
eigenmannmartin Jun 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions userdocker/config/default.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,15 @@
],
}

# The following arguments sets default values that can be
# overwritten by the user.
# Do not include these args in ARGS_AVAILABLE or ARGS_ALWAYS
ARGS_DEFAULT = {
'run': {
#'--memory': '50m'
}
}


# Volume mounts:
# - VOLUME_MOUNTS_ALWAYS will be mounted whether the user wants it or not
Expand Down
5 changes: 5 additions & 0 deletions userdocker/helpers/parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from ..config import ARGS_ALWAYS
from ..config import ARGS_AVAILABLE
from ..config import ARGS_DEFAULT


class _PatchThroughAssignmentAction(argparse._AppendAction):
Expand All @@ -29,6 +30,10 @@ def init_subcommand_parser(parent_parser, scmd):
patch_through_args=[],
)

for arg, val in ARGS_DEFAULT.get(scmd, {}).items():
parser.add_argument(arg, dest="patch_through_args", action=_PatchThroughAssignmentAction)
parser.set_defaults(patch_through_args=parser.get_default('patch_through_args') + [f'{arg}={val}'])

# patch args through
_args_seen = []
for args in ARGS_AVAILABLE.get(scmd, []) + ARGS_ALWAYS.get(scmd, []):
Expand Down