Add support for passing a timeout through to the whois query#117
Open
tow wants to merge 1 commit intojoepie91:masterfrom
Open
Add support for passing a timeout through to the whois query#117tow wants to merge 1 commit intojoepie91:masterfrom
tow wants to merge 1 commit intojoepie91:masterfrom
Conversation
|
Seems like a great idea (unless others have solved differently) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using pythonwhois for large numbers of queries, I find sometimes a whois query will hang (probably rate-limiting on the whois server)
It is useful to be able to put a timeout on the whois query so that the thread/application can recover from this failure.
This patch allows the get_whois caller to specify an optional timeout that will be applied to any connections to whois servers.