chore(skills): 同步上游 v5.1.0 worktree 安全修复(issue #19 第一批)#28
Open
jnMetaCode wants to merge 1 commit into
Open
Conversation
把 upstream/main v5.1.0 在 using-git-worktrees + finishing-a-development-branch 两个 skill 上的行为变更逐字翻译同步过来。属于上游修复 obra/superpowers#991 (subagent 自动创建嵌套 worktree、清理误删 harness-managed workspace)。 using-git-worktrees: - 新增 Step 0:GIT_DIR vs GIT_COMMON 检测现有隔离,submodule 守卫 - 新增创建前同意流程(除非 instructions 已声明偏好) - 重组 Step 1 为 1a Native Tools (首选) + 1b Git Worktree Fallback - 新增沙盒回退(permission error 时原地工作) - 删除旧"示例工作流"段(含 /Users/jesse 硬编码路径) - 保留章节编号 Step 1→3 的上游怪癖(不擅自"修正") finishing-a-development-branch: - 新增 Step 2 检测环境(三态表决定菜单形态和清理逻辑) - 旧 Step 2/3/4/5 重编号为 3/4/5/6 - Step 4 新增分离 HEAD 3 选项变体 - Step 5 Option 1 重写:MAIN_ROOT cwd safety + merge→verify→cleanup→delete 严格排序 - Step 5 Option 2 增加 "Do NOT cleanup worktree" 提示(PR 迭代需要) - Step 6 清理范围限定:只清 .worktrees/ / worktrees/ / ~/.config/superpowers/worktrees/ 之内的;外部 harness-managed workspace 一律不动(核心安全修复) - 红线 + 常见错误段扩展(按上游对应同步) 翻译原则: - 章节标题翻译,但保留章节编号 (Step 0/1/3/4 一一对应) - 代码块完全保留,不翻译变量名/命令 - 散文逐句翻译,不简化不扩写 - 我们独有的 "## 集成" 段保留(指向 brainstorming/subagent-driven-development 等) 不属于本 PR 范围: - review loop 简化(v5.0.6 brainstorming/writing-plans)→ 下一批 - code-reviewer 整合(v5.1.0 requesting-code-review)→ 下一批 - subagent 节奏调整 (v5.1.0 subagent-driven-development) → 下一批 - brainstorm server.cjs 脚本结构同步 (v5.0.6 CONTENT_DIR/STATE_DIR) → 单独 PR Refs: #19
This was referenced May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
你要解决什么问题?
上游
obra/superpowersv5.1.0 对using-git-worktrees和finishing-a-development-branch两个 skill 做了行为安全修复(参见 obra/superpowers#991),本 fork 当前 SKILL.md 内容仍停留在 v4.x/v5.0.5 之前的结构,导致:GIT_DIR != GIT_COMMON在 submodule 内也为真,旧版无守卫/Users/jesse/myproject/硬编码:旧"示例工作流"段含上游作者的本地路径,issue tracking: 同步上游 superpowers v5.0.6 / v5.1.0 关键 skill 变更 #19 列入清理项本 PR 是 issue #19 追踪清单里 v5.1.0 worktree 安全部分的第一批同步。
这个 PR 做了什么改变?
把上游 v5.1.0 在两个 worktree skill 上的所有行为变更逐字翻译同步:
using-git-worktrees/SKILL.md:/Users/jesse/myproject/硬编码)finishing-a-development-branch/SKILL.md:翻译原则:
这个改变适合放在核心库中吗?
适合。这是上游 core skill 的行为安全修复同步,对所有中文用户都生效,不针对任何具体项目/工具/工作流。
你考虑了哪些替代方案?
这个 PR 是否包含多个不相关的改变?
否。两个 skill 同属 worktree 子系统,行为联动(Step 0 检测 ↔ Step 6 清理)。本 PR 严格限定在 worktree 安全修复 scope 内。
明确不在本 PR 范围(issue #19 后续批次):
已有的 PR
测试环境
说明: 本 PR 是 SKILL.md 文档同步,不涉及代码执行路径。
结构对齐验证(本地):
grep -nE '^#{1,4} '比对:我方与 upstream/main 在 Step 0/1a/1b/3/4 + Step 2-6 章节结构 1:1 对齐GIT_DIR出现 10 处(v5.1.0 标志)、MAIN_ROOT6 处(cwd safety)、submodule 守卫 1 处、/Users/jesse硬编码 0 处评估
本 PR 是翻译同步性质,不是 skill 行为设计变更,所以无需对抗式 eval。措辞按上游逐句翻译,不改语义、不优化、不简化。
人类伙伴应做的下游 eval(合并后或本地试用本分支):
.worktrees/<existing-branch>内 cd 进去,触发任何调用 using-git-worktrees 的 skill,确认 Step 0 检测到并跳过创建.worktrees/路径工作区里走 Option 1 / Option 4,确认 Step 6 不会移除(提示由 harness 管理)严格性
人工审核