Claude/fix vertex layout logging i4zo8#74
Merged
Conversation
The snapshot vertex reader previously relied on extractors advancing the stream by exactly the element's natural size, with one Seek per vertex. Layouts with gaps between elements (e.g. Position/BlendWeight/BlendIndices/ Normal at offsets 0/12/16/20 followed by TextureCoordinate at offset 32) caused the reader to consume the 8-byte gap as the next element's data and silently skip the real data. Now we seek to vertStart + el.Offset before each element. Also logs once per layout when the pre-read stream position is below the declared element offset, surfacing layouts whose elements don't pack contiguously. Detection uses the stream position rather than a parallel table of element sizes.
- Sort vert elements when making id string for consistent hash code on result
Owner
Author
|
Fixes #75 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.