Refactor: optimize AntPathMatcher usage, eliminate code duplication and improve logging #5015
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and improve logging
- Task 1: Optimize AntPathMatcher instantiation
- Extract AntPathMatcher to static final field in RestAuthorizedUrlsRequestMatcher
- Extract AntPathMatcher to static final field in ReportAsResourceServerBeforeInvocationEventListener
- Extract AntPathMatcher to static final field in ReportOidcResourceServerBeforeInvocationEventListener
- Task 2: Eliminate code duplication in reports-rest module
- Create AbstractReportBeforeInvocationEventListener base class with common logic
- Refactor ReportAsResourceServerBeforeInvocationEventListener to extend base class
- Refactor ReportOidcResourceServerBeforeInvocationEventListener to extend base class
- Task 3: Improve logging by using SLF4J parameterized messages
- RestJsonTransformations: use {} placeholder instead of string concatenation
- ReportExecutionHistoryRecorderImpl: use {} placeholder for path logging
- LocalFileStorage: use {} placeholders for file path logging
- HtmlFormatter: use {} placeholders for fonts directory logging
- JavaProcessManager: use {} placeholder for process list logging
- LinuxProcessManager: use {} placeholder for process list and error logging
- WinProcessManager: use {} placeholder for process list and error logging
- OOServer: use {} placeholders for profile directory logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize AntPathMatcher instantiation
Eliminate code duplication in reports-rest module
Improve logging by using SLF4J parameterized messages